LG-10052 Validate Zip Code on "Enter the information on your state‑issued ID" page by gina-yamada · Pull Request #8554 · 18F/identity-idp

gina-yamada · 2023-06-08T16:04:50Z

🎫 Ticket

LG-10052 Validate Zip Code on "Enter the information on your state‑issued ID" page

🛠 Summary of changes

Removed maxlength to let regex handle length
Add regex pattern & error message (same pattern, same error as zip on residential address- see screenshot below 👇 )
Add as: tel for mobile numeric key (so it would behave the same as zip code on residential address- see screenshot below 👇 )

📜 Testing Plan

locally set in_person_capture_secondary_id_enabled to true
Create an account. Fail proofing to hit In Person Proofing Flow
Once on "Enter the information on your state‑issued ID" page" enter both valid and non-valid inputs
Observe validation/error message when validation failes
Confirm behave and error message is consist with residential address by selecting that you live at a different address

👀 Screenshots

Before:

No validation (length and characters)

After:

Has validation + error message

Passes Validation

Fails Validation

For Quick Reference here is a screenshot of app/views/idv/in_person/address.html.erb so you can see attributes for component

…on to zip code on State Id View

aduth

Can we add a regression spec for this?

This seems like a good candidate to extract to a common component (e.g. ZipCodeFieldComponent) to avoid future such inconsistency. Another thing I notice is this field probably doesn't have the Cleave formatting that other zipcode fields have, currently via formatted-fields.ts + the .zipcode class.

tomas-nava · 2023-06-08T16:58:09Z

Another thing I notice is this field probably doesn't have the Cleave formatting that other zipcode fields have, currently via formatted-fields.ts + the .zipcode class.

Added in f1ccf50

tomas-nava · 2023-06-08T17:08:00Z

This seems like a good candidate to extract to a common component (e.g. ZipCodeFieldComponent) to avoid future such inconsistency.

I created LG-10056 for this.

tomas-nava · 2023-06-08T19:05:40Z

Can we add a regression spec for this?

added in 4a57f23

…052-validate-zip-on-state-id

…m:18F/identity-idp into gyamada/lg-10052-validate-zip-on-state-id

gina-yamada · 2023-06-09T14:18:42Z

@aduth Thanks for the good suggestions yesterday. A few changes pushed up since you last reviewed. Now that the pipeline is fixed can I get a quick review and a thumbs up before merging? Thanks

aduth

LGTM 👍

aduth · 2023-06-09T15:16:52Z

spec/features/idv/steps/in_person/state_id_step_spec.rb

+  let(:remote_identity_proofing) { false }
+


Is this used for anything?

Suggested change

let(:remote_identity_proofing) { false }

removed with commit ba04a56

aduth · 2023-06-09T15:17:47Z

spec/features/idv/steps/in_person/state_id_step_spec.rb

@@ -0,0 +1,47 @@
+require 'rails_helper'
+require 'axe-rspec'


Is this needed?

Suggested change

require 'axe-rspec'

removed with commit ba04a56

aduth · 2023-06-09T15:18:11Z

spec/features/idv/steps/in_person/state_id_step_spec.rb

+RSpec.describe 'doc auth IPP state ID step', js: true do
+  include IdvStepHelper
+  include InPersonHelper
+  include VerifyStepHelper


Is this needed?

Suggested change

include VerifyStepHelper

removed with commit ba04a56

gina-yamada added 3 commits June 8, 2023 09:44

LG-10052 Add validation to zipcode on state_id

2311d4f

LG-10052 Fix lint issue

ba0f636

changelog: User-Facing Improvements, In-person proofing, Add validati…

9f160dc

…on to zip code on State Id View

aduth approved these changes Jun 8, 2023

View reviewed changes

This comment was marked as duplicate.

Sign in to view

sort fields, add cleave formatting

f1ccf50

add test for zipcode validation

4a57f23

Tomas Apodaca and others added 3 commits June 8, 2023 14:04

remove unneeded variables from test

a08ba5c

Merge branch 'main' of github.com:18F/identity-idp into gyamada/lg-10…

a294640

…052-validate-zip-on-state-id

Merge branch 'gyamada/lg-10052-validate-zip-on-state-id' of github.co…

f87d885

…m:18F/identity-idp into gyamada/lg-10052-validate-zip-on-state-id

aduth approved these changes Jun 9, 2023

View reviewed changes

LG-10052 Clean up unused items

ba04a56

gina-yamada merged commit 97cb3e4 into main Jun 9, 2023

gina-yamada deleted the gyamada/lg-10052-validate-zip-on-state-id branch June 9, 2023 15:53

jmhooper mentioned this pull request Jun 13, 2023

Deploy RC 288 to prod #8587

Merged

Comments

Conversation

gina-yamada commented Jun 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎫 Ticket

🛠 Summary of changes

📜 Testing Plan

👀 Screenshots

Passes Validation

Fails Validation

For Quick Reference here is a screenshot of app/views/idv/in_person/address.html.erb so you can see attributes for component

Uh oh!

aduth left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

tomas-nava commented Jun 8, 2023

Uh oh!

tomas-nava commented Jun 8, 2023

Uh oh!

tomas-nava commented Jun 8, 2023

Uh oh!

gina-yamada commented Jun 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aduth left a comment

Choose a reason for hiding this comment

Uh oh!

aduth Jun 9, 2023

Choose a reason for hiding this comment

Uh oh!

gina-yamada Jun 9, 2023

Choose a reason for hiding this comment

Uh oh!

aduth Jun 9, 2023

Choose a reason for hiding this comment

Uh oh!

gina-yamada Jun 9, 2023

Choose a reason for hiding this comment

Uh oh!

aduth Jun 9, 2023

Choose a reason for hiding this comment

Uh oh!

gina-yamada Jun 9, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gina-yamada commented Jun 8, 2023 •

edited

Loading

aduth left a comment •

edited

Loading

gina-yamada commented Jun 9, 2023 •

edited

Loading